Using jQuery this and matching off-wikia links

TheV1ct0ri0u5·5/1/2016 in Technical Advice & Coding Help

I am not very familiar with this, and therefore have likely used it wrong. It may also be the fact that I don't have an advanced knowledge of JavaScript or jQuery in any circumstance. I have regex that–to my knowledge–should catch all Wikia links, and exclude them from my element selection.

My main issue is that it seems to be catching all a elements, when I only want those which correspond with my if statement. I have my current code below.

$('a').each(function() {
    if($(this).attr('href') != /(((http|https)?:\/\/)?(((\w*\.)?\w*\.)?wikia\.com))?(\/wiki\/)?(\w*(:\w+)?)?(\?w+=.+)?/ ) {
        $(this).attr('target', '_blank');
    }
});

Any help is greatly appreciated!

(Edited by TheV1ct0ri0u5)

UltimateSupreme·5/1/2016

Use regex.test() to match with a Regular Expression

(Edited by UltimateSupreme)

TheV1ct0ri0u5·5/1/2016

Updated code

$('a').each(function() {
    if( /(((http|https)?:\/\/)?((\w*\.)?\w+\.wikia\.com))(\/wiki\/)?((\w+(:\w+)?)(%3Faction=(edit|history))?)/.test($('a').attr('href'))) {
        return false
    } else {
        $(this).attr('target', '_blank');
    }
});

The JavaScript part of it is working fine. Now the issue is the fact that \.wikia\.com is somehow matching google.com.

EDIT: I neglected the fact that external links have their own class. I've settled on just targeting this class instead of doing a regex comparison on the href value.

(Edited by TheV1ct0ri0u5)

What do you think?